Re: [PATCH] libfdt: add address translation support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Tue, 1 Apr 2014 18:02:38 -0500
Scott Wood <scottwood@xxxxxxxxxxxxx> wrote:

> On Tue, 2014-04-01 at 11:57 -0500, Rob Herring wrote:
> > From: Rob Herring <robh@xxxxxxxxxx>
> > 
> > Add FDT based address translation. Currently, only simple bus
> > translations are supported, but the framework allows adding other
> > buses like PCI. Adding this to libfdt allows the address
> > translation code to be shared amongst u-boot, Linux kernel and other
> > projects.
> > 
> > This code is based on GPL only licensed code. It must first be
> > re-licensed for dual GPL/BSD to add to libfdt which requires approval
> > from the copyright holders.
> > 
> > This code is copied from u-boot common/fdt_support.c. The portion used
> > here was originally added to u-boot by Kumar Gala in 2010 and Freescale
> > is the copyright holder. Later changes have also only been done by
> > Freescale authors. The u-boot code appears to have been copied from the
> > Linux kernel's address translation code in drivers/of/address.c which
> > has no copyright. This code was moved by Grant Likely in 2010 and
> > originated from arch/powerpc/kernel/prom_parse.c which was written by
> > Ben Herrenschmidt. Who is the copyright holder on a file in the kernel
> > with no copyright? Does this default to the author or Linus or nobody?
> 
> ACK for the Freescale contribution (on copyright issues, not technical -- see below).

FWIW, ack from me too.

> +/* Default translator (generic bus) */
> +static void fdt_bus_default_count_cells(void *blob, int parentoffset,
> +				 	int *addrc, int *sizec)

space before tab in indent (git am).

Also, thanks for not introducing new sparse warnings :)

Kim

--
To unsubscribe from this list: send the line "unsubscribe devicetree-compiler" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux