|
actually. the checklist do have corpus tests listed:
generate new object corpus for encoding/decoding tests
i'll ask Neha or someone else to approve the PR that is supposed to fix it
From: Gregory Farnum <gfarnum@xxxxxxxxxx>
Sent: Saturday, February 17, 2024 9:01 AM
To: Casey Bodley <cbodley@xxxxxxxxxx>
Cc: Nitzan Mordechai <nmordech@xxxxxxxxxx>; dev@xxxxxxx <dev@xxxxxxx>
Subject: [EXTERNAL] Re: ceph-object-corpus test coverage
I think we should make updating this a blocker for the squid release. Maintaining ceph-object-corpus has always been very ad-hoc so we should perhaps add it to release checklists. If there are specific failures in the object corpus tests, those
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
ZjQcmQRYFpfptBannerEnd
I think we should make updating this a blocker for the squid release. Maintaining ceph-object-corpus has always been very ad-hoc so we should perhaps add it to release checklists.
If there are specific failures in the object corpus tests, those should be directed to the relevant component leads/recent updaters, right?
-Greg
this ceph-object-corpus repo is the basis of our ceph-dencoder test
src/test/encoding/readable.sh, which verifies that we can still decode
all of the data structures encoded by older ceph versions
i'd like to raise awareness that this ceph-object-corpus repo hasn't
been updated with new encodings since pacific 16.2.0, so we're missing
important regression test coverage since then
Nitzan prepared the encodings for reef 18.2.0 in
https://github.com/ceph/ceph-object-corpus/pull/17,
but those haven't
merged yet. i had opened https://github.com/ceph/ceph/pull/54735 to
test that, but 'make check' identified failures like:
> The following tests FAILED:
> 147 - readable.sh (Failed)
>
> **** reencode of /home/jenkins-build/build/workspace/ceph-pull-requests/ceph-object-corpus/archive/18.2.0/objects/chunk_refs_t/ccb69d9ecd572c1f6ed9598899773cf1 resulted in a different dump ****
can we find a way to prioritize this? it would be great to have these
reef encodings while we're validating the squid release
_______________________________________________
Dev mailing list -- dev@xxxxxxx
To unsubscribe send an email to dev-leave@xxxxxxx
|
_______________________________________________
Dev mailing list -- dev@xxxxxxx
To unsubscribe send an email to dev-leave@xxxxxxx
