Great idea, Eric! Definitely that'd certainly save a lot of resources.
A small suggestion if I may: based upon your use-case, this will be mostly used to pick 1 or max 2 target releases, right?
So rather than relying on a new file inside some repo, what about defining this into the branch name? It feels like a bit hacky at first, but we already recommend a conventional branch name for ceph-ci (mostly for informational purposes), so we could simply extend that convention.
The current syntax is:
wip-<username>-testing-<date>-<branch> (e.g.: wip-spongebob-testing-2023-01-30-1500-quincy)
The proposed syntax would be (we have upto 250 chars to play with branch names):
wip-<username>-testing-<date>-<branch>-build_<distro> (e.g.: wip-spongebob-testing-2023-01-30-1500-quincy-build_centos9stream,debian12)
The main benefits of this are:
- Can be easily added to the "build-integration-branch" script (which basically generates a branch name by appending stuff),
- Jenkins allows to trigger jobs based on branch name patterns,
- In Shaman/Jenkins/Pulpito/etc., it would also be immediate to understand what releases a job/branch is building (no need to check out the branch code).
- Could be easily implemented in teuthology-suite to detect the available Shaman packages and run only those.
Kind Regards,
ErnestoOn Thu, Feb 2, 2023 at 7:19 PM J. Eric Ivancich <ivancich@xxxxxxxxxx> wrote:
It seems there must be some other repo involved with the processing scripts that use these .yml files. For example, when I look in ceph-build for a non-yml file that has some of the keys in the .yml files (e.g., "condition-kind"), I can’t find any. So that would seem to suggest that there’s some other repo containing scripts that I haven’t found yet.
Eric
(he/him)
> On Feb 2, 2023, at 1:01 PM, Gregory Farnum <gfarnum@xxxxxxxxxx> wrote:
>
> On Thu, Feb 2, 2023 at 9:50 AM Josh Durgin <jdurgin@xxxxxxxxxx> wrote:
>>
>> Greg, Eric's already made a change in the ceph-build PR linked, that's where this logic occurs.
>
> Durr, I skipped over the footnote and ceph-build is where I went first
> but its short description is "Helper scripts for building the official
> Ceph packages" so I thought I was in the wrong place. :D
>
_______________________________________________
Dev mailing list -- dev@xxxxxxx
To unsubscribe send an email to dev-leave@xxxxxxx
_______________________________________________ Dev mailing list -- dev@xxxxxxx To unsubscribe send an email to dev-leave@xxxxxxx
