Hi Dev folks,
I found that., on master, I can't currently do a "make install" if
I've disabled the dashboard. The proximate cause is this logic:
diff --git a/src/pybind/mgr/dashboard/CMakeLists.txt
b/src/pybind/mgr/dashboard/CMakeLists.txt
index 81bb9dd1bb2..452fdb433e2 100644
--- a/src/pybind/mgr/dashboard/CMakeLists.txt
+++ b/src/pybind/mgr/dashboard/CMakeLists.txt
@@ -16,8 +16,8 @@ if(WITH_MGR_DASHBOARD_FRONTEND)
endif()
else()
# prebuilt
- install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/frontend/dist
- DESTINATION ${CEPH_INSTALL_DATADIR}/mgr/dashboard/frontend)
- install(FILES frontend/package.json
- DESTINATION ${CEPH_INSTALL_DATADIR}/mgr/dashboard/frontend)
+# install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/frontend/dist
+# DESTINATION ${CEPH_INSTALL_DATADIR}/mgr/dashboard/frontend)
+# install(FILES frontend/package.json
+# DESTINATION ${CEPH_INSTALL_DATADIR}/mgr/dashboard/frontend)
endif()
Since in a normal build, the dependencies in the else case are not satisifed.
I'm looking for suggestions for fixing this. :)
regards,
Matt
--
Matt Benjamin
Red Hat, Inc.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103
http://www.redhat.com/en/technologies/storage
tel. 734-821-5101
fax. 734-769-8938
cel. 734-216-5309
_______________________________________________
Dev mailing list -- dev@xxxxxxx
To unsubscribe send an email to dev-leave@xxxxxxx
