Sage, if these failures aren't blocking you, I am ok waiting until Monday. But let us please not merge any bluestore PRs in the meantime. - Neha On Fri, Oct 22, 2021 at 7:21 AM Adam Kupczyk <akupczyk@xxxxxxxxxx> wrote: > > How about reverting it on Monday, if I do not fix it by then? > > On Fri, 22 Oct 2021 at 14:27, Igor Fedotov <ifedotov@xxxxxxx> wrote: >> >> I'm fine with both reverting and leaving it as-is for a couple more days.. So up to you guys... ;) >> >> On 10/22/2021 5:19 AM, Sage Weil wrote: >> >> Should we revert in the meantime? >> >> https://github.com/ceph/ceph/pull/43627 >> >> On Thu, Oct 21, 2021 at 6:32 PM Neha Ojha <nojha@xxxxxxxxxx> wrote: >>> >>> Looks like the rados/objectstore tests were passing until 2021-10-13 - >>> http://pulpito.front.sepia.ceph.com/yuriw-2021-10-13_23:21:13-rados-wip-yuriw-master-10.13.21-distro-basic-smithi/ >>> and started failing on 2021-10-15 - >>> http://pulpito.front.sepia.ceph.com/yuriw-2021-10-15_22:59:21-rados-wip-yuri-master-10.15.21-distro-basic-smithi/. >>> >>> Looking at the bluestore changes merged during this period >>> (https://github.com/ceph/ceph/commits/master/src/os), I'd suspect >>> https://github.com/ceph/ceph/pull/42099, but I could be wrong. FWIW, >>> the ceph_assert(file->fnode.ino) failure showed up in the testing of >>> that PR, see https://github.com/ceph/ceph/pull/42099#issuecomment-943424310 >>> (https://pulpito.ceph.com/kchai-2021-10-14_09:20:36-rados-wip-kefu-testing-2021-10-14-1507-distro-basic-smithi/6443182/). >>> >>> Igor/Adam, I will let you guys dig further. >>> >>> Thanks, >>> Neha >>> >>> >>> On Thu, Oct 21, 2021 at 2:05 PM Sage Weil <sage@xxxxxxxxxxxx> wrote: >>> > >>> > I'm seeing two ceph_test_objectstore failures on current master: >>> > >>> > ObjectStore/StoreTestSpecificAUSize.SyntheticMatrixCsumVsCompression/2 fails with >>> > 2021-10-21T19:39:03.941 INFO:teuthology.orchestra.run.smithi166.stderr:/build/ceph-17.0.0-8399-g9fda06aa/src/os/bluestore/BlueFS.cc: In function 'int BlueFS::_replay(bool, bool)' thread 7ff07ab77240 time 2021-10-21T19:39:03.932322+0000 >>> > 2021-10-21T19:39:03.944 INFO:teuthology.orchestra.run.smithi166.stderr:/build/ceph-17.0.0-8399-g9fda06aa/src/os/bluestore/BlueFS.cc: 1301: FAILED ceph_assert(file->fnode.ino) >>> > >>> > and ObjectStore/StoreTestSpecificAUSize.SpilloverFixedTest/2 fails with >>> > >>> > 2021-10-21T20:38:56.731 INFO:teuthology.orchestra.run.smithi102.stdout:/home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-8399-g9fda06aa/rpm/el8/BUILD/ceph-17.0.0-8399-g9fda06aa/src/test/objectstore/store_test.cc:9375: Failure >>> > 2021-10-21T20:38:56.732 INFO:teuthology.orchestra.run.smithi102.stdout:Expected equality of these values: >>> > 2021-10-21T20:38:56.732 INFO:teuthology.orchestra.run.smithi102.stdout: 0 >>> > 2021-10-21T20:38:56.732 INFO:teuthology.orchestra.run.smithi102.stdout: logger->get(l_bluefs_slow_used_bytes) >>> > 2021-10-21T20:38:56.732 INFO:teuthology.orchestra.run.smithi102.stdout: Which is: 217645056 >>> > >>> > These seem to trigger reliably: >>> > >>> > https://pulpito.ceph.com/sage-2021-10-21_18:03:47-rados:objectstore-master-distro-basic-smithi/ >>> > >>> > Are these known issues? >>> > sage >>> > >>> > _______________________________________________ >>> > Dev mailing list -- dev@xxxxxxx >>> > To unsubscribe send an email to dev-leave@xxxxxxx >>> >> >> _______________________________________________ >> Dev mailing list -- dev@xxxxxxx >> To unsubscribe send an email to dev-leave@xxxxxxx _______________________________________________ Dev mailing list -- dev@xxxxxxx To unsubscribe send an email to dev-leave@xxxxxxx
