Hi Ernesto, On Tue, Dec 15, 2020 at 3:21 AM Ernesto Puerta <epuertat@xxxxxxxxxx> wrote: > > Hi all, > > After automating the per-component labelling in Pull Requests, this next PR is adding automation to the `needs-rebase` label with the help of this Github Action. > > When the base branch (e.g.: master) of a PR is updated and the PR merge results in conflicts: > > `needs-rebase` label will automatically be added. > `ready-to-merge` label will be removed Are we already using this "ready-to-merge" label? What does it mean exactly? That the PR is already QA'd and just needs merged or that the PR has no conflicts? In any case, it does not seem useful to me and adds visual clutter to the label list. > The following comment will be added: "This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved". > > When the PR is rebased, conflict solved and re-pushed: > > The `needs-rebase` label will be automatically removed (`ready-to-merge` label won't be added back though) Otherwise, a very useful change. Thanks for your efforts on it! -- Patrick Donnelly, Ph.D. He / Him / His Principal Software Engineer Red Hat Sunnyvale, CA GPG: 19F28A586F808C2402351B93C3301A3E258DD79D _______________________________________________ Dev mailing list -- dev@xxxxxxx To unsubscribe send an email to dev-leave@xxxxxxx
