Re: Ceph API tests required for Ceph Pull Requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

thanks a lot Ernesto for the detailed write-up!

Now that https://tracker.ceph.com/issues/47306 ("rgw: FAIL: test_all (tasks.mgr.dashboard.test_rgw.RgwBucketTest)") has been resolved, the nightly tests in the master are passing again:

https://jenkins.ceph.com/view/mgr-dashboard/job/ceph-api-nightly-master-backend/

Thanks a lot to the RGW team and Ernesto for analyzing and resolving this bug. Let's try to keep this test passing from now on!

If the API test is still marked as "failed" on your pending pull requests, try running "jenkins test api" to re-run it. If the test still fails on any of your PRs afterwards, please pay close attention to the failure and let us know if you need any help with finding the root cause.

Lenz

On 9/9/20 6:15 PM, Ernesto Puerta wrote:

At the CLT meeting today there's been agreement to *make Ceph API tests "required" *again for Pull Request to be merged:

  * The current approach (/"honoring the agreement not to merge failing
    PRs"/) is simply not working: PRs have been merged with API tests in
    red. While most of these are harmless due to random failures (/we
    are working to improve this/), other times API tests warned about
    real issues... which eventually slipped into the code. [1]
    <https://tracker.ceph.com/issues/47306> [2]
    <https://tracker.ceph.com/issues/45717> [3]
    <https://github.com/ceph/ceph/pull/36091>
  * The cost & risk of debugging issues a posteriori is usually higher
    than the pain of retriggering the API tests (/we are working to
    improve this/).
  * Ceph API tests, even with their downsides, are providing true
    integration testing at CI time: this doesn't simply mean complex
    unit tests or component testing, it means running a vstart Ceph
    cluster and actually testing RADOS, RBD, RGW, CephFS...

--
SUSE Software Solutions Germany GmbH - Maxfeldstr. 5 - 90409 Nuernberg
GF: Felix Imendörffer, HRB 36809 (AG Nürnberg)

Attachment: OpenPGP_0xE66F1B6ADBDDA420_and_old_rev.asc
Description: application/pgp-keys

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

_______________________________________________
Dev mailing list -- dev@xxxxxxx
To unsubscribe send an email to dev-leave@xxxxxxx

[Index of Archives]     [CEPH Users]     [Ceph Devel]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux