On Thu, Aug 20, 2020 at 8:54 PM Yuval Lifshitz <ylifshit@xxxxxxxxxx> wrote: > > it has a lua-5.3-ceph branch, so I guess that some changes were done for ceph. yes, see https://github.com/ceph/lua/commits/lua-5.3-ceph. but i think at least part of the change can be done right in src/CMakeLists.txt without changing the included lua/CMakeLists.txt. Noah simply hard coded all of them in https://github.com/ceph/lua/commit/1bd5df6724cbad1a39ccfe071c15881439784c80 . > > will use the submodule. > > > On Thu, Aug 20, 2020 at 3:42 PM Matt Benjamin <mbenjami@xxxxxxxxxx> wrote: >> >> ISTR that when Lua scripting was added with the Mantle project, there >> may have been some modification of the Lua system as part of the >> integration. I might be wrong about that, or there might be no trace >> of that left, but ...? >> >> Matt >> >> On Thu, Aug 20, 2020 at 7:59 AM Nathan Cutler <presnypreklad@xxxxxxxxx> wrote: >> > >> > > does anyone know why we have lua5.1 as a ceph submodule [1]? >> > > the latest lua is available for many linux distros (centos/rhel, ubuntu, fedora, opensuse, etc.), why not add it to install-deps.sh? >> > >> > Presumably for the same reason we have boost as a submodule. >> > >> > Past experience has shown that the version of foo (lua in this case) >> > can vary from distro to distro. Also, each distro is a "moving target" >> > in that the version of foo (lua in this case) can change, with >> > consequences that are impossible to predict, at any time. >> > >> > HTH, >> > Nathan >> > _______________________________________________ >> > Dev mailing list -- dev@xxxxxxx >> > To unsubscribe send an email to dev-leave@xxxxxxx >> > >> >> >> -- >> >> Matt Benjamin >> Red Hat, Inc. >> 315 West Huron Street, Suite 140A >> Ann Arbor, Michigan 48103 >> >> http://www.redhat.com/en/technologies/storage >> >> tel. 734-821-5101 >> fax. 734-769-8938 >> cel. 734-216-5309 >> > _______________________________________________ > Dev mailing list -- dev@xxxxxxx > To unsubscribe send an email to dev-leave@xxxxxxx -- Regards Kefu Chai _______________________________________________ Dev mailing list -- dev@xxxxxxx To unsubscribe send an email to dev-leave@xxxxxxx
