On 10:27 Sun 17 May, Yehuda Sadeh-Weinraub wrote: > On Sat, May 16, 2020 at 4:33 PM Liu, Changcheng > <changcheng.liu@xxxxxxxxx> wrote: > > > > Hi all, > > I'm trying to accelerate base64 encode/decode in Ceph. > > > > Why do we implement it in this way? Which version of base64 RFC is > > followd by Ceph? > > > > It is common to have base64 strings that have line breaks in them, so > our decoding function needs to be able to handle that whether we use > it or not. We do have ceph_armor_line_break() that can be used in > theory (although it's not being used right now). There are cases where > we need to handle base64 strings that were encoded by external > sources, so code needs to be resilient and handle these cases. Could you show which acutal usage needs to decode the '\n' in the encoded base64 string? Which base64 RFC is followd by Ceph? What's extra changes are added based the standard used RFC? --Changcheng > > Yehuda > _______________________________________________ Dev mailing list -- dev@xxxxxxx To unsubscribe send an email to dev-leave@xxxxxxx
