On Mon, Mar 23, 2020 at 11:22 AM Kuniyuki Iwashima <kuniyu@xxxxxxxxxxxx> wrote: > > When we get a TCP_NEW_SYN_RECV/DCCP_NEW_SYN_RECV socket by > __inet_lookup_skb(), refcounted is already set true, so it is not > necessary to do it again. This changelog is absolutely not accurate. sk is a listener here. (because sk was set to req->rsk_listener;) Please do not add confusion by mixing different things. I prefer not relying on the old value of 'refcounted', since we switched sk value. Note that we call reqsk_put(req); regardless of 'refcounted' I would rather not change this code and make future backports more complicated. Thanks.
