From: Yue Haibing <yuehaibing@xxxxxxxxxx> Date: Fri, 22 Mar 2019 21:43:48 +0800 > From: YueHaibing <yuehaibing@xxxxxxxxxx> > > If dccp_feat_push_change fails, we forget free the mem > which is alloced by kmemdup in dccp_feat_clone_sp_val. > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values") > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> > --- > v2: kfree 'val --> 'fval' Don't submit any patches for at least 2 days, I am getting really tired of changes you don't even COMPILE TEST: CC [M] net/dccp/feat.o net/dccp/feat.c: In function ʽ__feat_register_spʼ: net/dccp/feat.c:742:13: error: invalid type argument of ʽ->ʼ (have ʽdccp_feat_valʼ {aka ʽunion <anonymous>ʼ}) kfree(fval->sp.vec); ^~