Re: [PATCH net] dccp: avoid deadlock in dccp_v4_ctl_send_reset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
Date: Fri, 08 Jul 2016 11:03:57 +0200

> From: Eric Dumazet <edumazet@xxxxxxxxxx>
> 
> In the prep work I did before enabling BH while handling socket backlog,
> I missed two points in DCCP :
> 
> 1) dccp_v4_ctl_send_reset() uses bh_lock_sock(), assuming BH were
> blocked. It is not anymore always true.
> 
> 2) dccp_v4_route_skb() was using __IP_INC_STATS() instead of
>   IP_INC_STATS()
> 
> A similar fix was done for TCP, in commit 47dcc20a39d0
> ("ipv4: tcp: ip_send_unicast_reply() is not BH safe")
> 
> Fixes: 7309f8821fd6 ("dccp: do not assume DCCP code is non preemptible")
> Fixes: 5413d1babe8f ("net: do not block BH while processing socket backlog")
> Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> Reported-by: Dmitry Vyukov <dvyukov@xxxxxxxxxx>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux