>The only patch that has an issue is #2: this reintroduces a problem which > occurred earlier when performing feature negotiation during the initial > handshake. Since your patch set targets feature negotiation in established > state, there should be a way to enable both - i.e. keep the old behaviour > for the initial, and use the new one for the established state. I'm working on slightly modifying the patch to fix this issue. Will repost shortly. > Other issues that would be good to resolve before uploading the patches: > * some have minor codingstyle issues, I am ok to fix stuff up to some > degree; but please consider scripts/checkpatch.pl I actually did run that script over these patches, and the script reported no problems. I've re-read the codingstyle document and don't see anything clearly wrong. What am I doing that's not standard coding style? > * could you add comments (short descriptions) about conditions you observed, > or add pointers to documentation webpages in the commit message? It helps > in future discussions to come back on track faster. I'll do that. Right now, I'm making the changes you suggested to the patches. I hope to repost them shortly. Samuel Jero Internetworking Research Group Ohio University
Attachment:
signature.asc
Description: This is a digitally signed message part
