Em Thu, Jan 14, 2010 at 03:15:17PM -0500, Neil Horman escreveu: > Hey- > This was just recently reported to me. When built as modules, > the dccp_probe module has a silent dependency on the dccp module. This stems > from the fact that the module_init routine of dccp_probe registers a jprobe on > the dccp_sendmsg symbol. Since the symbol is only referenced as a text string > (the .symbol_name field in the jprobe struct) rather than the address of the > symbol itself, depmod never picks this dependency up, and so if you load the > dccp_probe module without the dccp module loaded, the register_jprobe call fails > with an -EINVAL, and the whole module load fails. > > The fix is pretty easy, we can just wrap the register_jprobe call in a > try_then_request_module call, which forces the dependency to get satisfied prior > to the probe registration. > > I've verified that this fixes the problem myself. > > Regards > Neil > > Signed-off-by: Neil Horman <nhorman@xxxxxxxxxxxxx> That is ok with me, thanks! Acked-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe dccp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
