| > -int ccid_unregister(struct ccid_operations *ccid_ops)
| > +static int ccid_unregister(struct ccid_operations *ccid_ops)
| > {
<snip>
|
| And "register/unregister" now don't make much sense since there is no
| registration being done, just allocating/deallocating resources
|
Yes agree - this needs revision. We can also drop the EXPORT_SYMBOLS
from the now-static routines.
| > +
| > +static struct ccid_operations *ccid_find_by_id(const u8 id)
| > {
| > - struct ccid *ccid = kmem_cache_alloc(rx ? ccid_ops->ccid_hc_rx_slab :
| > - ccid_ops->ccid_hc_tx_slab, gfp);
| > + int i;
| > +
| > + for (i = 0; i < ARRAY_SIZE(ccids); i++)
| > + if (ccids[i]->ccid_id == id)
| > + return ccids[i];
| > + return NULL;
|
| Why the we searching? Can't we just do:
|
| {
| if (id > ARRAY_SIZE(ccids) - 2)
| return NULL;
| return ccids[id - 2];
| }
|
Agree 100%, I don't like the routine myself and have been thinking about
how to rewrite it. Current idea is to go back to the original and use
static struct ccid_operations *ccids[CCIDS_MAX] = {
[DCCPC_CCID2] = &ccid2_ops,
#ifdef CONFIG_IP_DCCP_CCID3
[DCCPC_CCID3] = &ccid3_ops,
#endif
};
And then use
if (id < 0 || id >= CCIDS_MAX)
return NULL;
return ccids[id];
which may be NULL if there is no entry in the array. Better?
Gerrit
--
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
