Re: [PATCH 6/7] dccp: Remove manual influence on NDP Count feature

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Gerrit Renker <gerrit@xxxxxxxxxxxxxx>
Date: Sat,  6 Dec 2008 17:40:56 +0100

> Updating the NDP count feature is handled automatically now:
>  * for CCID-2 it is disabled, since the code does not use NDP counts;
>  * for CCID-3 it is enabled, as NDP counts are used to determine loss lengths.
> 
> Allowing the user to change NDP values leads to unpredictable and failing
> behaviour, since it is then possible to disable NDP counts even when they
> are needed (e.g. in CCID-3).
> 
> This means that only those user settings are sensible that agree with the
> values for Send NDP Count implied by the choice of CCID. But those settings
> are already activated by the feature negotiation (CCID dependency tracking),
> hence this form of support is redundant.
> 
> At startup the initialisation of the NDP count feature uses the default
> value of 0, which is done implicitly by the zeroing-out of the socket when
> it is allocated. If the choice of CCID or feature negotiation enables NDP
> count, this will then be updated via the NDP activation handler.
> 
> Signed-off-by: Gerrit Renker <gerrit@xxxxxxxxxxxxxx>
> Acked-by: Ian McDonald <ian.mcdonald@xxxxxxxxxxx>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux