Hi Dave,
please find below the revised patch set.
Thank you for taking the time to look through.
If we could keep this set going on as a low-key background process, that
would be great. I found the pace not only more reviewer-friendly, but also
more submitter-friendly, so it is in fact a good choice.
Regards
Gerrit
Changes relative to revision 2
------------------------------
* reordered patches to eliminate build warnings (reducing patch sizes);
* in addition, sparse-build warnings were also eliminated;
* all patches again verified to compile without build errors.
Changes relative to revision 1
------------------------------
* [1/5] streamlined field layout reducing the size per each entry;
* [2/5] migration of function 'dccp_default_value' to a later in the set
where it is first used.
Commit summary
--------------
This is the first set of the feature negotiation patches. These provide a
self-contained feature negotiation API for the DCCP protocol (RFC 4340-2).
The whole set is structured into 3 main blocks - (1) basis, (2) core,
(3) integration and cleanup. Within these blocks, this is the first,
self-contained, set and its purpose is to provide
(a) the underlying datastructures
(b) initialisation and cleanup routines for the new datastructures.
List of patches in this set:
----------------------------
Patch #1: Provides the basic datastructure for feature negotiation. It gets
around the problem that feature-negotiation values have no uniform
type - they can be 48-bit numbers, single characters, 2-byte integers
or a list of unsigned chars.
Patch #2: Provides a lookup-table for the different negotiable features.
Patch #3: Adds list management for the list keeping the negotiation-options.
Patch #4: Initialisation routines (for request sockets and normal sockets).
Patch #5: Analogous to #4, this provides the cleanup routines.
The set is also available for viewing online, beginning at
http://eden-feed.erg.abdn.ac.uk/cgi-bin/gitweb.cgi?p=dccp_exp.git;a=commitdiff;h=6370e843d9977eff8f2a1bbb18020d5fbc36b202
Patch stats:
------------
include/linux/dccp.h | 13 ++-
net/dccp/dccp.h | 5 +
net/dccp/feat.c | 167 +++++++++++++++++++++++++++++++++++++++++++++++++++
net/dccp/feat.h | 62 ++++++++++++++++++
net/dccp/input.c | 2
net/dccp/ipv4.c | 4 -
net/dccp/ipv6.c | 4 -
net/dccp/minisocks.c | 7 +-
net/dccp/proto.c | 3
9 files changed, 256 insertions(+), 11 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
