Re: CCID4 Testing - bug fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 12 May 2008 8:38:39 pm Gerrit Renker wrote:
> | Since the reduction applies to X_calc only, IMHO it should be moved like
> | this:
> |
> |     /* Update sending rate (step 4 of [RFC 3448, 4.3]) */
> |         if (hctx->p > 0) {
> |             hctx->x_calc = tfrc_calc_x(NOM_PACKET_SIZE,
> |                                        hctx->rtt, hctx->p);
> |
> |             /* Apply header penalty as per RFC 4828, 4.2 */
> |             hctx->x_calc *= hctx->s;
> |             do_div(hctx->x_calc, hctx->s + CCID4HCTX_H);
> |     }
>
> No that won't work since it only changes X_calc. So it is probably all
> well to just delete the call to  ccid4_hc_tx_x_header_penalty() below
> "} else if (ktime_us_delta(now, h", as on your website.
>
>
> The University of Aberdeen is a charity registered in Scotland, No
> SC013683.

We have done our tests removing the 2nd "ccid4_hc_tx_x_header_penalty()" after
the "else if" and it seems to work. The graphs for the "patched ccid4" (200ms
and 1000ms) will testify the results.

Could anyone point me to some instructions on howto request/commit changes
done on dccp codes downloaded from: git://eden-feed.erg.abdn.ac.uk/dccp_exp ?

Thank you Gerrit for your replies.

-babil.
--
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux