Re: [PATCH 3/4] [CCID2]: Replace broken RTT estimator with better algorithm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



| >  +                * Decay RTTVAR at most once per flight, exploiting that
| >  +                *  1) pipe <= cwnd <= Sequence_Window = W  (RFC 4340, 7.5.2)
| >  +                *  2) AWL = GSS-W+1 <= GAR <= GSS          (RFC 4340, 7.5.1)
| >  +                * GAR is a useful bound for FlightSize = pipe, AWL is probably
| >  +                * too low as it over-estimates pipe.
| >  +                */
| >  +               if (after48(dccp_sk(sk)->dccps_gar, hctx->ccid2hctx_rtt_seq)) {
| >  +                       if (hctx->ccid2hctx_mdev_max < hctx->ccid2hctx_rttvar)
| >  +                               hctx->ccid2hctx_rttvar -= (hctx->ccid2hctx_rttvar - hctx->ccid2hctx_mdev_max) >> 2;
| 
| More than 80 chars in this line! 87 chars. Is this ok?
| 
There are actually 120 characters in this line. The 80-characters constraint
has become a recommendation, i.e. it is possible and legal to make exceptions.
I kept it in to allow a better comparison to the original TCP code.

If anything, it shows how the ubiquitous `hctx->ccid?hctx_' prefixes make
it hard to read the code.
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux