Sorry I only got this email today and it is a busy day, too.
The changes look good and are in general a further improvement on the
code. I like the idea of hiding the internals of the list structure in
the source file.
I wonder if one could go one step further and also take the timestamp
directly when looking up the previous history sample, e.g.
u32 tfrc_tx_hist_rtt(struct tfrc_tx_hist_entry *head, const u64 seqno)
{
u32 rtt = 0;
struct tfrc_tx_hist_entry *packet = tfrc_tx_hist_find_entry(head, seqno);
if (packet != NULL) {
rtt = ktime_us_delta(ktime_get_real(), packet->stamp);
/*
* Garbage-collect older (irrelevant) entries:
*/
tfrc_tx_hist_purge(&packet->next);
}
return rtt;
}
Just a suggestion.
Thanks for looking through this.
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
