Re: [PATCH 4/25] Set packet size to 1460 as per ccid-4 draft

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



| |  	if (hctx->ccid4hctx_p > 0)
| | -		hctx->ccid4hctx_x_calc = tfrc_calc_x(hctx->ccid4hctx_s,
| | +		hctx->ccid4hctx_x_calc = tfrc_calc_x(NOM_PACKET_SIZE,
| |  						     hctx->ccid4hctx_rtt,
| |  						     hctx->ccid4hctx_p);
<snip>
| The above code is CCID3 with the difference that s = 1460. To better
| share the code between CCID3/4, I think it would be simpler to
| initialise `s' with this value, and to dispense with the `update_s'
| routine that CCID3 uses.
| 
| Like, for example in ccid4_hc_tx_init:
| 	{
| 		/* ... */
| 		hctx->ccid4hctx_s = NOM_PACKET_SIZE;
| 
| 	}
| 
| Then one could consider sharing tx_packet_recv code.
Nope. The above is nonsense, I've just realised the way `s' is used, so
the comment does not really apply, please forget that.

Using the moving-average as in CCID3, as you do, is probably a good
idea, since when the packet size is varied in response to congestion
the spikes will be smoothed out be the earlier averages.
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux