Quoting Tommi: | On Wed, Oct 31, 2007 at 21:30:24 -0300, Leandro wrote: | > [CCID-3/4 lib] Initial lib for sharing common code between ccid-3/ccid-4 | > | > The lib is called tfrc_ccids.o | | > Index: leandro.new/net/dccp/ccids/lib/Makefile | > =================================================================== | > --- leandro.new.orig/net/dccp/ccids/lib/Makefile | > +++ leandro.new/net/dccp/ccids/lib/Makefile | > @@ -1,4 +1,5 @@ | > obj-$(CONFIG_IP_DCCP_TFRC_LIB) += dccp_tfrc_lib.o | > | > dccp_tfrc_lib-y := tfrc_module.o tfrc_equation.o \ | > - packet_history.o loss_interval.o | > + packet_history.o loss_interval.o \ | > + tfrc_ccids.o | | Whitespace police hits! I don't remember Documentation/CodingStyle | mentioning anything about whitespaces in Makefiles. Nevertheless, | packet_history.o is indented here with spaces, tfrc_ccids.o with | tabulators, I think we should stick to just one kind of whitespace. | | > - packet_history.o loss_interval.o | > + packet_history.o loss_interval.o \ | > + tfrc_ccids.o | Leandro is right, tabs are ok in this place (it is a line continuation). I just found that in the online version the patch looks as suggested above (I run my whitespace scripts routinely over patch sets, and have done this here as well). - To unsubscribe from this list: send the line "unsubscribe dccp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
