Quoting Ian McDonald: | > --- a/include/linux/dccp.h | > +++ b/include/linux/dccp.h | > @@ -372,7 +372,6 @@ static inline unsigned int dccp_hdr_len( | > #define DCCPF_INITIAL_SEQUENCE_WINDOW 100 | > #define DCCPF_INITIAL_ACK_RATIO 2 | > #define DCCPF_INITIAL_CCID DCCPC_CCID2 | > -#define DCCPF_INITIAL_SEND_ACK_VECTOR 1 | > /* FIXME: for now we're default to 1 but it should really be 0 */ | > #define DCCPF_INITIAL_SEND_NDP_COUNT 1 | > | Not sure if the fixme applies to ack_vector or send_ndp_count so | unsure if that should be removed also. Well spotted - the FIXME applies to NDP count, both lines are removed in [PATCH 13/14]: Initialisation and type-checking of feature sysctls which has the following hunk: @@ -368,13 +368,6 @@ static inline unsigned int dccp_hdr_len( } -/* initial values for each feature */ -#define DCCPF_INITIAL_SEQUENCE_WINDOW 100 -#define DCCPF_INITIAL_ACK_RATIO 2 -#define DCCPF_INITIAL_CCID DCCPC_CCID2 -/* FIXME: for now we're default to 1 but it should really be 0 */ -#define DCCPF_INITIAL_SEND_NDP_COUNT 1 - The hardcoded constants are replaced by looking up the default value for the feature in the feat.c-lookup table (which itself has the defaults from 6.4). Changes from global settings can be enforced by setting socket options. - To unsubscribe from this list: send the line "unsubscribe dccp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
