On 10/4/07, Gerrit Renker <gerrit@xxxxxxxxxxxxxx> wrote: > [DCCP]: Remove manual influence on NDP Count feature > > The NDP count feature is handled automatically now by the feature negotiation code: > * for CCID2 it is disabled, since the code does not use or even refer to NDP counts; > * for CCID3 it is enabled, since NDP counts are used to determine loss lengths (RFC 4342, 6.1). > > Allowing the user to change these values leads to unpredictable and failing behaviour, since it > is then possible to disable NDP counts even when they are needed (e.g. in CCID3). This means that > only those user settings are sensible that agree with the values for Send NDP Count implied by the > choice of CCID. But those settings are already activated by the feature negotiation (CCID dependency > tracking), which means that the user settings are redundant. > > I thus think that it is the best choice to remove this sysctl. Leaving it in brings no > advantages, but opens a door to creating non-operable conditions. > > At startup the initialisation of the NDP count feature is with the default value of 0, which is > done implicitly by the zeroing-out of the socket when it is allocated. If the choice of CCID or > feature negotiation enables NDP count, this will then be updated via the NDP activation handler. > > Signed-off-by: Gerrit Renker <gerrit@xxxxxxxxxxxxxx> Acked-by: Ian McDonald <ian.mcdonald@xxxxxxxxxxx> - To unsubscribe from this list: send the line "unsubscribe dccp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
