Re: [PATCH v2 4/9]: Resolve dependencies of features on choice of CCID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Arnaldo Carvalho de Melo:
|  > +             {       /* !is_local: dependencies of the remote (RX) CCID */
|  > +                     { DCCPF_SEND_ACK_VECTOR, true,  true, 1 },
|  > +                     { 0, 0, 0, 0 }
|  
|  designated initializers, please, that way we can avoid the zeroes and
|  see the name of the fields, which helps understanding without having to
|  go back to the struct definition.
I can add the field-wise initialisers, but have no way of getting rid of the zeroes
at the moment. The problem is that 
 * the dependencies of the feature-location can be different from 
 * the dependencies of the feature-remote
as is indeed the case with ccid3_dependencies[2][5]: it which has three dependencies for the
feature-remote, but four for the feature-local.

So the tables can be variable in length, even in their two main rows. The number of
rows (2), on the other hand, is given by the requirement that features divide into
local/remote, so there is no problem using a fixed-length. 
If you can think of a more elegant solution of tackling this, I'd welcome suggestions.

Will axe the `const typedef' stuff, thanks.
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux