On 10/2/07, Gerrit Renker <gerrit@xxxxxxxxxxxxxx> wrote: > [DCCP]: Auxiliary function for smallest-fit option lengths > > This introduces a function to determine the smallest-fit data type to carry options, > which is used by the feature-negotiation code to insert option values. > > While doing this, I found that the same code is required to set the NDP length, > whose length is variable between 1..6 bytes (RFC 4340, 7.7). > > There seem to be remains of the old code base when apparently NDP count was only 3 > bytes long. I have removed the annotations, as well as an unused constant limiting > the maximum NDP value to 3 bytes, and added a FIXME to increase the data type for > NDP up to u64. I didn't want to add this to this patch also, since various other > parts (e.g. CCID3) implicitly rely on u32. For the moment, u32 seems to more than > ample anyway, so the FIXME could even remain until there is a `high-speed' CCID. > > Signed-off-by: Gerrit Renker <gerrit@xxxxxxxxxxxxxx> Acked-by: Ian McDonald <ian.mcdonald@xxxxxxxxxxx> - To unsubscribe from this list: send the line "unsubscribe dccp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
