Re: [PATCH 8/9]: Set per-connection CCIDs via socket options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/29/07, Gerrit Renker <gerrit@xxxxxxxxxxxxxx> wrote:
> [DCCP]: Set per-connection CCIDs via socket options
>
> With this patch, TX/RX CCIDs can now be changed on a per-connection basis, which
> overrides the defaults set by the global sysctl variables for TX/RX CCIDs.
>
> To make full use of this facility, the remaining patches of this patch set are
> needed, which track dependencies and activate negotiated feature values.
>
> Signed-off-by: Gerrit Renker <gerrit@xxxxxxxxxxxxxx>

Acked-by: Ian McDonald <ian.mcdonald@xxxxxxxxxxx>

But see one comment below.

> +       BUILD_BUG_ON(sizeof(u8) != 1);

The whole point of u8 is that it is one byte as is u16 2 bytes etc. If
these change then the whole kernel breaks so this check is
unnecessary.

Ian
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux