Quoting Arnaldo Carvalho de Melo: | > +/* Find smallest-fit for @value, but not more than 6 bytes (current maximum) */ | > +static inline u8 dccp_bytes_per_value(const u64 value) | > +{ | > + if (value > 0xFFFFFFFFull) | > + return 6; | > + return value > 0xFFFF? 4 : (value > 0xFF? 2 : 1); | | Gerrit, one more coding style request: please always add an space after | the '?'. Thank you for spotting - I will take this `home' and do the same for all patches in the test tree. I wish I could save you these requests, but the question of space or not space was not very clear to me - I could find Will in any case also re-read Documentation/CodingStyle and update the patches if anything is not conform. Gerrit - To unsubscribe from this list: send the line "unsubscribe dccp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html