Re: [PATCH 1/8]: Add FIXME for send_delayed_ack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/26/07, Gerrit Renker <gerrit@xxxxxxxxxxxxxx> wrote:
> [DCCP]: Add FIXME for send_delayed_ack
>
> This adds a FIXME to signal that the function dccp_send_delayed_ack is nowhere
> used in the entire DCCP/CCID code.
>
> Using a delayed Ack timer is suggested in 11.3 of RFC 4340, but it has also
> rather subtle implications for the Ack-Ratio-accounting.
>
> CCID2 does not use this (maybe it should).
>
> I think leaving the function in is good, in case someone wants to implement
> this.
>
> Signed-off-by: Gerrit Renker <gerrit@xxxxxxxxxxxxxx>

How about using #if 0, #endif around it to keep the code in the tree
but not compiled.

This is done a fair bit elsewhere and if never used it gets removed.

Ian
-- 
Web1: http://wand.net.nz/~iam4/
Web2: http://www.jandi.co.nz
Blog: http://iansblog.jandi.co.nz
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux