2007/9/20, Ian McDonald <ian.mcdonald@xxxxxxxxxxx>:
> On 9/21/07, ツ Leandro Sales <leandroal@xxxxxxxxx> wrote:
> > Hello Gerrit,
> >
> > From now and as I was talking to Ian two days ago, after our
> > patchset for initial code of ccid-4, I'm identifying functions between
> > ccid-4 and ccid-3 that will remains unchangeable. What do you think if
> > we try to define something like a common_ccid34.{c/h} and make common
> > functions between ccid-4 and ccid-3 available into this source file?
> > Or this will make the code a little bit confused?
> >
> > Leandro.
> >
> Leandro,
>
> Firstly - I think these discussions are better on list. Can we open to list.
>
> Thinking some more about this I've thought about this some more. I
> think what we're bettter to do is to get CCID4 code to use CCID3 code
> rather than create a new file. This is because CCID4 references CCID3
> but not the other way around.
>
> It will also be messy if we then get CCID5 etc.
>
> So what I suggest you might need to do is shift more ccid3
> declarations into ccid3.h and included this. It might also need
> removal of some static from function declarations and adding of
> EXPORT_SYMBOL_GPL to existing CCID3 code.
>
> This way you are still sharing code but it is clear CCID4 is based on CCID3.
>
> Regards,
>
> Ian
> --
> Web1: http://wand.net.nz/~iam4/
> Web2: http://www.jandi.co.nz
> Blog: http://iansblog.jandi.co.nz
>
Exactly! I was thinking about this since my first patchset sent via an
URL, where I commented about this. The problem of doing like you
suggested (move some code from ccid3.c to ccid3.h) is it will require
an approval about you and the others, such as gerrit and arnaldo, at
least if this is the right process to follow. Anyway, I'm already
identifying the candidate codes to be shared between ccid3 and ccid4
if you didn't this yet. Another option is wait for gerrit suggestion
on this issue and discuss more about that and define a strategy to
avoid code repetition.
Leandro.
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
