Re: [PATCH 4/4] CCID4: Replaces the hard-coded 1460 nominal packet size by a #define

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2007/9/20, Tommi Saviranta <wnd@xxxxxx>:
> On Thu, Sep 20, 2007 at 14:55:09 -0300, ツ Leandro Sales wrote:
> > diff -uprN dccp-ccid4.base/net/dccp/ccids/ccid4.h
>
> > +#define NOM_PACKET_SIZE                 1460
>
> Agreed, using a define for hardcoded value is the way to go. I think
> nominal packet size is somewhat private information to ccid4.c, so I'd
> rather put the define in the c-file. What does the Linux-kernel coding
> convention (or common sense) say about this?
>
>

Put NOM_PACKET_SIZE into ccid4.h follows the other definition, similar to
#define TFRC_T_MBI 64
that goes into ccid4.h too.

Leandro.
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux