On 9/13/07, Gerrit Renker <gerrit@xxxxxxxxxxxxxx> wrote: > Quoting Ian McDonald: > | On 9/13/07, Gerrit Renker <gerrit@xxxxxxxxxxxxxx> wrote: > | > [DCCP]: Fix Request/Response RTT sampling > | > > Thanks for looking at this, but I won't/can't use the sign-off, since > I merged this patch with the one which had the error fixed by this patch. > OK. Reviewed the merged patch now. > ---------------------> Updated Patch #3, fixed by 5/5 <----------------------- > [DCCP]: Simplify interface of dccp_sample_rtt > > The third parameter of dccp_sample_rtt now becomes useless and is removed. > > Also combined the subtraction of the timestamp echo and the elapsed time. > This is safe, since (a) presence of timestamp echo is tested first and (b) > elapsed time is either present and non-zero or it is not set and equals 0 > due to the memset in dccp_parse_options. > > To avoid measuring option-processing time, the timestamp for measuring the > initial Request/Response RTT sample is taken directly when the function is > called (the Linux implementation always adds a timestamp on the Request, > so there is no loss in doing this). > > Signed-off-by: Gerrit Renker <gerrit@xxxxxxxxxxxxxx> Signed-off-by: Ian McDonald <ian.mcdonald@xxxxxxxxxxx> -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To unsubscribe from this list: send the line "unsubscribe dccp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
