Re: [PATCH 4/6] DCCP: Add framework for faster restart

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



|  Set up options for enabling TFRC options. Also add variables for faster
|  restart.
|  
|  Signed-off-by: Ian McDonald <ian.mcdonald@xxxxxxxxxxx>
Signed-off-by: Gerrit Renker <gerrit@xxxxxxxxxxxxxx>

I think a small optimisation is possible below:

|  +static int ccid3_hc_rx_setsockopt(struct sock *sk, const int optname,
|  +				  int val, int optlen)
|  +{
|  +	struct ccid3_hc_rx_sock *hcrx = ccid3_hc_rx_sk(sk);
|  +
|  +	/* Listen socks don't have a private CCID block */
|  +	if (sk->sk_state == DCCP_LISTEN)
|  +		return -EINVAL;
This check appears now 6 times in the CCID3 code. I think it could be moved to
the wrapper functions ccid_hc_{t,r}x_getsockopt and - with regard to your previous patch -
to ccid_hc_{t,r}x_setsockopt.

What I am working on is resolving this "Listen socks don't have a private CCID block" business,
i.e. trying to get away from passing all the CCID control blocks to the control socket and let
the connection do the negotiation.
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux