Re: [PATCH 07/15] Convert dccp_sample_rtt to ktime_t

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



After a bit more testing, I found that this one has one bug.

|  @@ -593,22 +591,21 @@ EXPORT_SYMBOL_GPL(dccp_rcv_state_process);
|    * @t_recv: receive timestamp of packet with timestamp echo
|    * @t_hist: packet history timestamp or NULL
|    */
|  -u32 dccp_sample_rtt(struct sock *sk, struct timeval *t_recv,
|  -				     struct timeval *t_hist)
|  +u32 dccp_sample_rtt(struct sock *sk, ktime_t t_recv, ktime_t *t_hist)
|   {
|   	struct dccp_sock *dp = dccp_sk(sk);
|   	struct dccp_options_received *or = &dp->dccps_options_received;
|  -	suseconds_t delta;
|  +	s64 delta;
|   
|   	if (t_hist == NULL) {
|   		if (!or->dccpor_timestamp_echo) {
|   			DCCP_WARN("packet without timestamp echo\n");
|   			return DCCP_SANE_RTT_MAX;
|   		}
|  -		timeval_sub_usecs(t_recv, or->dccpor_timestamp_echo * 10);
|  -		delta = timeval_usecs(t_recv);
|  +		ktime_sub_us(t_recv, or->dccpor_timestamp_echo * 10);
|  +		delta = ktime_to_us(t_recv);
==> It should read
    t_recv = ktime_sub_us(t_recv, or->dccpor_timestamp_echo * 10);
    the statement is otherwise void.

-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux