Ian McDonald wrote: | > +/* internal includes that this module exports: */ | > +struct tfrc_rx_hist; | > +struct tfrc_loss_hist; | > +#include "loss_interval.h" | > +#include "packet_history.h" | > | | Variable definitions in the middle of an include block? Is that | necessary? I just haven't seen that done before and it looks a little | odd... | You are right, that is ugly, which is why I have changed it - see subsequent patch. The forward declarations of the two structures are needed since both sub-units -- receiver history and (receiver) loss detection work tightly together * the RX history does loss detection and needs to know where to pass on a newly identified loss. This is done by tfrc_rx_handle_loss() which talks to struct tfrc_loss_hist. * the loss interval database needs to access information stored in the receiver history record when creating a new loss interval, to identify whether a loss event starts a new loss interval, and for several internal uses. This is done in tfrc_lh_interval_add(), which talks to struct tfrc_loss_hist. - To unsubscribe from this list: send the line "unsubscribe dccp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
