Re: [PATCH 2/5]: History access is redundant when sending feedback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Ian McDonald:
|  > This patch
|  >   1. removes redundant use of packet history for sending feedback
|  >      (data packet is no longer `found', just referenced);
|  >   2. which obsoletes function dccp_rx_hist_find_data_packet - removed;
|  >   3. removes an irrelevant state `TERM' (feedback is then not sent);
|  >   4. removes redundant variable `last_ack' (duplicates `last_feedback');
|  >   5. converts rx_send_feedback() to use the newer timeofday interface;
|  >   6. simplify the computation of p/p_inv (see note below).
|  >
|  Great - making code much simpler - makes it easier for people like me
|  to understand!
... and people like me too. I think it is good to keep code as simple as possible,
to better see the interactions. Thank you for really going through the patches
individually, I'd especially appreciate input for further simplifications. After
talking to Arnaldo recently, there is at least one further patch to further reduce 
- removing redundant initialisations with `0' in tx_init/rx_init.
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux