Quoting Arnaldo Carvalho de Melo:
| > @@ -298,7 +298,7 @@ static void ccid2_hc_tx_packet_sent(stru
| > int rc;
| >
| > ccid2_pr_debug("allocating more space in history\n");
| > - rc = ccid2_hc_tx_alloc_seq(hctx, CCID2_SEQBUF_LEN, GFP_KERNEL);
| > + rc = ccid2_hc_tx_alloc_seq(hctx, CCID2_SEQBUF_LEN, gfp_any());
| > BUG_ON(rc); /* XXX what do we do? */
| >
| > next = hctx->ccid2hctx_seqh->ccid2s_next;
|
| This one is better than the one I came up with, will use it. But ccid2
| needs a major rework, the BUG_ON that appears here is horrendous!
Agree but didn't feel competent to make a better suggestion. One idea that comes to
mind is
/* check if we need to alloc more space */
if (next == hctx->ccid2hctx_seqt) {
if (ccid2_hc_tx_alloc_seq(...)) {
DCCP_CRIT("can not allocate");
return;
}
// ...
}
I wonder if it is possible to integrate with the TFRC list - but just made that
one singly-linked.
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
