Re: [PATCH 3/6]: Ignore trivial amounts of elapsed time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/17/07, Gerrit Renker <gerrit@xxxxxxxxxxxxxx> wrote:
The processing all happens in softirq context and the flow of function calls
is in the processing path of the handler.

OK - makes more sense. When grepping around in code I see CCID2 also
makes calls to elpased time fn. Haven't checked whether this can be
removed also...

Signed-off-by: Ian McDonald <ian.mcdonald@xxxxxxxxxxx>

The only way I can see that we will get a delay is in the case when skb allocation
fails in dccp_send_ack. This is something to be considered, but this (memory allocation
failture) seems to be an exception-case, not a rule-case. Hence it is implicitly added
to the processing/RTT delay of the host. To me this seems right: if the host is struggling
to get memory for skbs, it doesn't seem `right' to indicate to the other side that
the elapsed time = time to find an unallocated skb is negligible.
Thoughts?

Agree - if you are failing to allocate memory there are far bigger
issues and exact RTT timing is probably the least of your issues!

Ian
--
Web: http://wand.net.nz/~iam4/
Blog: http://iansblog.jandi.co.nz
WAND Network Research Group
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux