On 6/14/07, Gerrit Renker <gerrit@xxxxxxxxxxxxxx> wrote:
[TFRC]: Provide central source file and debug facility
This patch changes the tfrc_lib module in the following manner:
(1) a dedicated tfrc_module source file (this is later populated
with TX/RX hist and LI Database routines);
(2) a dedicated tfrc_pr_debug macro with toggle switch `tfrc_debug'.
The first serves to make the source code structure clearer, since module
initialisation and module parameter statements are currently spread over
loss_interval.c and packet_history.c (which are part of the tfrc_lib).
Do you intend to get rid of either of these or are we just increasing
number of files?
There is no functional change in this patch: but subsequent patches will
contribute module initialisation/cleanup routines (left open for now).
I'll signoff on it trusting that the changes to come make it worthwhile.
Point (2) provides a functionality which is available in all other DCCP
modules already: module debugging is enabled via a Kconfig option, in the
running code, debugging output can be toggled via the module parameter
`tfrc_debug'. So far, one had to resort to dccp_pr_debug for this, but it
is not a good idea since it destroys the logical module separation and makes
tfrc_lib debugging dependent on dccp main-module debugging flags.
NB: TFRC debugging is enabled via Kconfig dependency on CCID3 debug,
since CCID3 is currently the only `customer' of the TFRC library.
Signed-off-by: Gerrit Renker <gerrit@xxxxxxxxxxxxxx>
Signed-off-by: Ian McDonald <ian.mcdonald@xxxxxxxxxxx>
--
Web: http://wand.net.nz/~iam4/
Blog: http://iansblog.jandi.co.nz
WAND Network Research Group
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
