Re: [PATCH 19/25]: Remove unused fields in packet history structure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Arnaldo Carvalho de Melo:
|  struct dccp_tx_hist_entry {
|          struct list_head           dccphtx_node;         /*     0    16 */
|          u64                        dccphtx_seqno;        /*    16     8 */
|          struct timeval             dccphtx_tstamp;       /*    24    16 */
|  }; /* size: 40, cachelines: 1 */
|     /* last cacheline: 40 bytes */
|  [acme@mica net-2.6.22]$
|  
|  I wonder if we could make this a single linked list, lemme see.. I
|  think so, and by doing that we get the struct down to 32 bytes, making
|  it cacheline friendly, and also simplify the operations, i.e. that
|  opencoded list operation would just go away, will leave this for
|  later, in a TODO file.
This is an excellent idea - I have just checked. It works, there is no sorting
and just LIFO order. 

Will you be working on this or would you like me to update this in terms of 
struct hlist_head?
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux