Re: [PATCH 1/1] DCCP: Fix up t_nom - FOLLOW-UP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/8/07, Eddie Kohler <kohler@xxxxxxxxxxx> wrote:
>> - ccid3_hc_tx_send_packet should return a value that is measured in
>> MICROSECONDS not milliseconds.  It also sounds like there is a
>> rounding error
>> in step 3a); it should probably return (delay + 500)/1000 at least.
>>
> This is used to set a timer to know when to wake up again which is
> valid to be in msecs. We don't want to be firing interrupts in usec
> intervals as too intensive and that's why you have t_gran there.

You want it to return microseconds precisely so you can distinguish between
cases that require a timer and cases that require something lighterweight,
like a simple rescheduling.  If you pre-truncate the information to
millisecond granularity there's no way to distinguish between "send NOW" and
"send pretty soon but not now".  Just divide by 1000 when you actually
schedule the timer.

I'm not sure about this. If you reschedule you've got no guarantee
when you get your next timeslice. I also think that timers probably
aren't that heavy in Linux as it probably weights the scheduler. If
you ask for something 5 msecs in future you are guaranteed it won't go
off before then but sometime after..

Probably one to test some time but I can't see this affecting things
too much and bigger bugs to fry at present probably. But certainly
worth checking at some point.

Ian
--
Web: http://wand.net.nz/~iam4
Blog: http://iansblog.jandi.co.nz
WAND Network Research Group
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux