Quoting Ian McDonald: | On 12/2/06, Gerrit Renker <gerrit@xxxxxxxxxxxxxx> wrote: | | > [DCCP]: Add protection against invalid parameters to TFRC routines | > | > + BUG_ON(p > 1000000); /* p must not exceed 100% */ | > + BUG_ON(p == 0); /* f(0) = 0, divide by zero */ | | I know I put the original BUG_ONs in but can we change this to a | DCCP_BUG or a WARN - just to prevent the possible issues depending on | bottom half context... I thought about this too and initially both were DCCP_BUG_ON(). However, this just delays the Kerboom! -- as I have had to learn painfully: * case `p > 1000000' leads to accessing illegal memory - kernel panics * case `p == 0' leads to division by zero I have had one kernel Oops because of not making them DCCP_BUG_ON. The good side of using this is safety: if this condition is met, we will know from console output, and we will also know that there is serious trouble somewhere else. - To unsubscribe from this list: send the line "unsubscribe dccp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
