On 11/28/06, Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx> wrote:
On 11/28/06, Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx> wrote:
> On 11/28/06, Ian McDonald <ian.mcdonald@xxxxxxxxxxx> wrote:
> > > OK, additionally I'm replacing:
> > >
> > > + DCCP_WARN("sockopt(PACKET_SIZE) is deprecated: fix your app\n");
> > > + err = -EINVAL;
> > >
> > > By
> > >
> > > + DCCP_WARN("sockopt(PACKET_SIZE) not yet supported\n");
> > > + err = -EINVAL;
> > >
> > > To better reflect what we've discussed so far.
> > >
> > No deprecate it still. My earlier patches split it into two - a tx and
> > rx packet size.
>
> Oh, I see, OK.
Applied the "deprecated" patch, and on top of that another that makes
it return 0, not -EINVAL, so that the warning is emitted to the system
logs but the app continues working, reflecting the comment that says
it is has no effect.
End result :-)
[root@qemu ~]# ttcp-r: buflen=256, nbuf=2048, align=16384/+0,
port=5001 dccp(inet)
[root@qemu ~]#
[root@qemu ~]# [ 377.670389] CCID: Registered CCID 2 (ccid2)
ttcp-r: socket
/[ 377.891025] do_dccp_setsockopt: sockopt(PACKET_SIZE) is
deprecated: fix your app
[root@qemu ~]# ttcp -cacme -l256 -n1000 -t localhost &
[2] 494
[root@qemu ~]# ttcp-t: buflen=256, nbuf=1000, align=16384/+0,
port=5001 dccp(inet) -> localhost
ttcp-t: socket
[ 382.235316] do_dccp_setsockopt: sockopt(PACKET_SIZE) is deprecated:
fix your app
ttcp-r: accept from localhost.ghostprotocols.net
ttcp-t: connect
ttcp-t: 256000 bytes in 22.98 real seconds = 10.88 KB/sec +++
ttcp-t: 1000 I/O calls, msec/call = 23.53, calls/sec = 43.51
ttcp-t: 0.2user 17.0sys 0:22real 75% 0i+0d 0maxrss 0+1pf 0+1000csw
ttcp-r: 256000 bytes in 23.31 real seconds = 10.73 KB/sec +++
ttcp-r: 1001 I/O calls, msec/call = 23.84, calls/sec = 42.95
ttcp-r: 0.1user 5.0sys 0:23real 22% 0i+0d 0maxrss 0+1pf 1001+6csw
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
