On 11/29/06, Gerrit Renker <gerrit@xxxxxxxxxxxxxx> wrote:
[DCCP]: Use `unsigned' for packet lengths
I'm wondering whether this code is 64 bit safe??? I don't think it is. Arnaldo can probably advise. We changed int to u32 for length and I went and checked the callers and parameters. They all basically go back to skb->len which is an unsigned int. So at least we did the right thing changing to unsigned as we were mismatched before. As much as I would like to change sk_buff definition to __u32 and save 2 bytes on 64 bit I don't think we can really as that is in a userspace include as I understand it and therefore we would break programs... Regards, Ian -- Ian McDonald Web: http://wand.net.nz/~iam4 Blog: http://imcdnzl.blogspot.com WAND Network Research Group Department of Computer Science University of Waikato New Zealand - To unsubscribe from this list: send the line "unsubscribe dccp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
