On 11/24/06, Gerrit Renker <gerrit@xxxxxxxxxxxxxx> wrote:
[DCCP]: Simplify dccp_rcv_state_process This patch does not change the algorithm, it just simplifies control flow a bit. The main changes are: * cleanup after dccp_rcv_request_sent_state_process is now done within that function, not in dccp_rcv_state_process * as a result the control flow in dccp_rcv_request becomes a bit simpler
Gerrit, this one I have mixed feelings, as the simplification seems OK, but the principle of staying as close to the TCP counterpart (tcp_rcv_synsent_state_process) was the reason for me to leave parts of the cleanup to the caller, because in TCP land we need to do further processing with the skb before freeing it, so I'd prefer, for now, not to deviate too much, even in simple things like this one. - Arnaldo - To unsubscribe from this list: send the line "unsubscribe dccp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
