Re: [PATCH 3/6]: Fix calculation of t_ipi time of scheduled transmission

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



|  Gerrit - I was not trying to cast dispersions on you at all. I just
|  wanted some time to review it properly as I've spent a bit of time in
|  this code and would like to review CCID3 changes before they merge.
I understand this and this is the main reason why only send small, incremental patches; and
strive to give a justification for each step. In this way it is easier to verify whether the
changes actually improve the code or if they are not necessary. What I want to avoid is 
messing up someone else's code.

|  >   ==> Since these bits are so similar, I would actually suggest to accommodate them in
|  >       one function, since:
|  >                 --t_ipi changes only if one of `s' or X_calc changes
|  >                 --if `s' / X_calc remain unchanged after feedback, t_ipi remains as before
|  >                 --t_delta depends on t_ipi
|  >                 --the calculation of t_nom depends on t_ipi (as in the above snippets)
|  >
|  
|  Agree.
Since your last email I have spent some more time going through the standard documents; if you
agree then it may be good to update - will review and prepare patches for review.
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux