Re: [PATCH 3/6]: Fix calculation of t_ipi time of scheduled transmission

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



    * the packet is sent now whenever t_now >= t_nom + t_delta
      instead of                      t_now >  t_nom - t_delta
      ==> this incurs a performance degradation, since 2*t_delta is spent unnecessarily

Yes you are right here. This is a bug

+                * if (t_now > t_nom - delta)
+                *       // send the packet now
+                * else
+                *       // send the packet in (t_nom - t_now) milliseconds.
+                */
+               if (delay < hctx->ccid3hctx_delta)
+                       rc = 0;
+               else
+                       rc = delay/1000L;

Shouldn't that last line be rc = (delay-hctx->ccid3hctx_delta)/1000 as
you're not taking the delta into account on the else clause.

Ian
--
Ian McDonald
Web: http://wand.net.nz/~iam4
Blog: http://imcdnzl.blogspot.com
WAND Network Research Group
Department of Computer Science
University of Waikato
New Zealand
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux