Re: [RFC] [PATCH]: use explicit enums for CCID 3 states

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/15/06, Gerrit Renker <gerrit@xxxxxxxxxxxxxx> wrote:
|  Anyway, there are always tradeoffs, compiler gets more info, but we
|  end up using more memory per socket instance, I guess we can stay like
|  we are now, no? :-)
That is why I sent it as RFC in the first place: it is not broken but would
be good to have.

I will think about a solution without changing the socket fields,
would BUG be ok instead of the more verbose output? But then, it is not so
terribly important, it just makes the code harder to understand.

Well, I'd rather prefer a WARN_ON type, probably rate limiting the
printks, so that we can receive reports that something is fishy but
don't panic the machine.

|
|  Probably because we stop using a u64 bitfield in the rx case...
Yes it is irksome - could not find anything to put in the 4-bit hole.

-- Gerrit

-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux