Re: [PATCH] Portability of dash to legacy systems, such as AT&T Unix PC : 10-ctype

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Tue, Nov 12, 2024 at 11:42:47PM +0100, Alain Knaff wrote:
> 
> The 10th patch fixes the handling of the "functions" supplied by
> ctype.h
> 
> On many older platforms, those are not real functions but preprocessor
> macros, so it is not possible to take a function pointer of them.
> 
> Dash's current approach of wrapping them into real functions would
> work if prototypes for these functions were available somewhere.
> 
> I took a different approach, which is to replace the table of names
> and function pointers with a cascade of ifs, makes for shorter code as
> well.

This doesn't apply anymore because of multi-byte character support:

commit c5bf9702ea110bede687b57c0b5fa3fd0e15829e
Author: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date:   Sun Jun 2 09:28:59 2024 +0800

    expand: Add multi-byte support to pmatch

    Add CTLMBCHAR support to pmatch.

    POSIX equivalence classes and collating symbols are not unsupported.

    Enable CTLMBCHAR generation in mbtodest.

    Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt