Hi, On 16/02/2024 16:33, Fabrice Fontaine wrote:
Drop -Wl,--fatal-warnings with --enable-static to avoid the following static build failure: configure:4778: checking for strtod configure:4778: /home/autobuild/autobuild/instance-8/output-1/host/bin/powerpc-buildroot-linux-uclibcspe-gcc -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -mabi=spe -mfloat-gprs=single -Wa,-me500 -Os -g0 -static -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -static -Wl,--fatal-warnings conftest.c >&5 /home/autobuild/autobuild/instance-8/output-1/host/lib/gcc/powerpc-buildroot-linux-uclibcspe/8.4.0/../../../../powerpc-buildroot-linux-uclibcspe/bin/ld: warning: conftest has a LOAD segment with RWX permissions collect2: error: ld returned 1 exit status
Where is this warning coming from? Does it show a real problem that needs to be addressed?
As for the actual patch, you're right that configure should not be using -Wl,--fatal-warnings, it should be avoided there for the same reason -Werror should be, the warnings that get promoted to errors differ between toolchain versions and in general, it is not possible to ensure that all valid toolchains, all valid warning flags, result in no warnings.
I suspect though that it was added for a reason, that there were things that *should* cause configure checks to fail, that did not fail except with -Wl,--fatal-warnings. Whatever that reason may have been, it will need to be handled differently if -Wl,--fatal-warnings is dropped. Unfortunately, it was added to dash back in 2007 before the current mailing list existed, so I am having trouble finding any explanation for what those errors may have been.
Dropping it sounds good to me if no one can tell why it is there, but I would suggest some experimentation may be in order to try and figure that out first.
Cheers, Harald van Dijk
